[shader_recompiler] Simplify translate loop and directly call (the now uniform functions); remove repetitive declarations on impl.h (#2972)

Function polymorphism where it wasn't needed? especially on tight code loops like translating code and whatnot?
You may think the compiler was fine with this but nah, it just made codegen for all those paths; I didn't check LTO but I'd assume it behaves the same (since the "black box" from most walkers suck) - basically bunch of code that isn't longer used
Also uniformly declaring all functions (i.e same args, return value) makes the entire switch statment way nicer

Signed-off-by: lizzie lizzie@eden-emu.dev

Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/2972
Reviewed-by: crueter <crueter@eden-emu.dev>
Reviewed-by: MaranBr <maranbr@eden-emu.dev>
Reviewed-by: CamilleLaVey <camillelavey99@gmail.com>
Co-authored-by: lizzie <lizzie@eden-emu.dev>
Co-committed-by: lizzie <lizzie@eden-emu.dev>

src/shader_recompiler/frontend/maxwell/translate/impl/not_implemented.cpp

@@ -39,7 +39,7 @@ void TranslatorVisitor::BRK(u64) {
     ThrowNotImplemented(Opcode::BRK);
 }
 
-void TranslatorVisitor::CAL() {
+void TranslatorVisitor::CAL(u64) {
     // CAL is a no-op
 }
 
@@ -155,7 +155,7 @@ void TranslatorVisitor::JMP(u64) {
     ThrowNotImplemented(Opcode::JMP);
 }
 
-void TranslatorVisitor::KIL() {
+void TranslatorVisitor::KIL(u64) {
     // KIL is a no-op
 }
 
@@ -172,14 +172,14 @@ void TranslatorVisitor::LONGJMP(u64) {
 }
 
 void TranslatorVisitor::NOP(u64) {
-    // NOP is No-Op.
+    // NOP is a no-op
 }
 
-void TranslatorVisitor::PBK() {
+void TranslatorVisitor::PBK(u64) {
     // PBK is a no-op
 }
 
-void TranslatorVisitor::PCNT() {
+void TranslatorVisitor::PCNT(u64) {
     // PCNT is a no-op
 }
 
@@ -239,7 +239,7 @@ void TranslatorVisitor::SETLMEMBASE(u64) {
     ThrowNotImplemented(Opcode::SETLMEMBASE);
 }
 
-void TranslatorVisitor::SSY() {
+void TranslatorVisitor::SSY(u64) {
     // SSY is a no-op
 }