From 5b1613087c9c9a53833b4dd3db82b49de54efa12 Mon Sep 17 00:00:00 2001 From: CamilleLaVey Date: Sat, 22 Aug 2026 01:07:34 -0400 Subject: [PATCH] Changes requested by reviewer meower --- src/core/hle/service/nvdrv/devices/nvhost_ctrl_gpu.h | 6 +++--- .../frontend/maxwell/translate_program.cpp | 3 +-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/core/hle/service/nvdrv/devices/nvhost_ctrl_gpu.h b/src/core/hle/service/nvdrv/devices/nvhost_ctrl_gpu.h index ede658c50f..6d6294e06d 100644 --- a/src/core/hle/service/nvdrv/devices/nvhost_ctrl_gpu.h +++ b/src/core/hle/service/nvdrv/devices/nvhost_ctrl_gpu.h @@ -212,12 +212,12 @@ private: Kernel::KEvent* unknown_event; // ZBC Tables - static constexpr u32 zbc_table_size = 15u; + static constexpr u32 ZBC_TABLE_SIZE = 15u; static constexpr u32 supported_types = 2u; std::mutex zbc_mutex{}; - std::array zbc_colors{}; - std::array zbc_depths{}; + std::array zbc_colors{}; + std::array zbc_depths{}; u32 zbc_used_color_entries{}; u32 zbc_used_depth_entries{}; }; diff --git a/src/shader_recompiler/frontend/maxwell/translate_program.cpp b/src/shader_recompiler/frontend/maxwell/translate_program.cpp index 44635a1425..0bb404b78b 100644 --- a/src/shader_recompiler/frontend/maxwell/translate_program.cpp +++ b/src/shader_recompiler/frontend/maxwell/translate_program.cpp @@ -472,8 +472,7 @@ void ConvertLegacyToGeneric(IR::Program& program, const Shader::RuntimeInfo& run program.info.legacy_stores_mapping = GenerateLegacyToGenericMappings(stores, unused_output_generics, {}); for (IR::Block* const block : program.post_order_blocks) { - auto it{block->begin()}; - while (it != block->end()) { + for (auto it = block->begin(); it != block->end();) { IR::Inst& inst{*it}; if (inst.GetOpcode() != IR::Opcode::SetAttribute || !IsLegacyAttribute(inst.Arg(0).Attribute())) {