From 5b86242313ecc8fd81c90e4678dcd2e59dcb13bb Mon Sep 17 00:00:00 2001 From: xbzk Date: Sun, 23 Aug 2026 00:29:59 +0200 Subject: [PATCH] [android, ui] remove the wash (white tint) of focused game cards (#4285) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - [x] I have read and followed the [Contribution Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions). - [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md) - [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md) to the best of my ability. ------------------- This removes the ugly wash from focused game cards, without removing the interaction's cool ripple effects. I've stumbled upon a reddit complaining about it, and in fact i always hated it but hadn't realized yet. It happens to any layout. Joypad users notice more since navigation consists on focusing cards. Carousel users notice even more coz cards are bigger and always focused. Border is more than enough to highlight a card, and we want to cherish colors just like creator artists wanted it to be, right? No chance of bugs. No chance of disagreement (¬¬). Approve it already so Youtube videos with carousel thumbs get prettier earlier ^^. Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4285 Reviewed-by: Samuel Reviewed-by: MaranBr --- src/android/app/src/main/res/color/game_card_ripple.xml | 8 ++++++++ .../app/src/main/res/layout-land/card_game_carousel.xml | 1 + .../app/src/main/res/layout/card_game_carousel.xml | 1 + src/android/app/src/main/res/layout/card_game_grid.xml | 1 + .../app/src/main/res/layout/card_game_grid_compact.xml | 1 + src/android/app/src/main/res/layout/card_game_list.xml | 1 + 6 files changed, 13 insertions(+) create mode 100644 src/android/app/src/main/res/color/game_card_ripple.xml diff --git a/src/android/app/src/main/res/color/game_card_ripple.xml b/src/android/app/src/main/res/color/game_card_ripple.xml new file mode 100644 index 0000000000..84a5dab29e --- /dev/null +++ b/src/android/app/src/main/res/color/game_card_ripple.xml @@ -0,0 +1,8 @@ + + + + + + + + diff --git a/src/android/app/src/main/res/layout-land/card_game_carousel.xml b/src/android/app/src/main/res/layout-land/card_game_carousel.xml index 4d8e5fd148..866b189042 100644 --- a/src/android/app/src/main/res/layout-land/card_game_carousel.xml +++ b/src/android/app/src/main/res/layout-land/card_game_carousel.xml @@ -10,6 +10,7 @@ android:clipChildren="true" android:layout_margin="0dp" app:cardBackgroundColor="@color/eden_card_background" + app:rippleColor="@color/game_card_ripple" app:strokeWidth="1dp" app:strokeColor="@color/eden_border"> diff --git a/src/android/app/src/main/res/layout/card_game_carousel.xml b/src/android/app/src/main/res/layout/card_game_carousel.xml index 424d6cadde..4e92a3e209 100644 --- a/src/android/app/src/main/res/layout/card_game_carousel.xml +++ b/src/android/app/src/main/res/layout/card_game_carousel.xml @@ -11,6 +11,7 @@ app:cardCornerRadius="16dp" app:cardPreventCornerOverlap="true" android:clipChildren="true" + app:rippleColor="@color/game_card_ripple" android:layout_margin="4dp">