From c5f6f1ca5eaf16ff84aee7987c0c8d37a1d9d2b2 Mon Sep 17 00:00:00 2001 From: lizzie Date: Wed, 9 Sep 2026 13:18:43 +0200 Subject: [PATCH] [common/host_memory] Remove throw on benign path (#4359) The caller of GetFuncAddress already handles the case gracefully. Fixes crashes when the symbol aint present Signed-off-by: lizzie - [x] I have read and followed the [Contribution Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions). - [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md) - [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md) to the best of my ability. ------------------- Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4359 Reviewed-by: CamilleLaVey Reviewed-by: Maufeat --- src/common/host_memory.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/common/host_memory.cpp b/src/common/host_memory.cpp index fa30b2c047..dd0780a283 100644 --- a/src/common/host_memory.cpp +++ b/src/common/host_memory.cpp @@ -117,7 +117,6 @@ template static void GetFuncAddress(Common::DynamicLibrary& dll, const char* name, T& pfn) { if (!dll.GetSymbol(name, &pfn)) { LOG_CRITICAL(HW_Memory, "Failed to load {}", name); - throw std::bad_alloc{}; } }