From f4a8f9421a9181e7a5062d8856da74823933defa Mon Sep 17 00:00:00 2001 From: lizzie Date: Sat, 29 Aug 2026 20:59:57 +0200 Subject: [PATCH] [common/net] fix linking errors due to C++11 ABI typedef mishandle (#4260) Signed-off-by: lizzie - [x] I have read and followed the [Contribution Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions). - [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md) - [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md) to the best of my ability. ------------------- basically bunch of linking errors due to gcc not liking to compile HFA/whatever typedef stuffs this is on non-x86_64 arch, ppc64 compiler where this occurs ``` gcc (Debian 14.2.0-19) 14.2.0 Copyright (C) 2024 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. ``` Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4260 Reviewed-by: MaranBr Reviewed-by: Maufeat --- src/common/net/net.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/common/net/net.h b/src/common/net/net.h index b07caabe20..77c80d9dc3 100644 --- a/src/common/net/net.h +++ b/src/common/net/net.h @@ -11,14 +11,14 @@ namespace Common::Net { -typedef struct { +struct Asset { std::string name; std::string url; std::string path; std::string filename; -} Asset; +}; -typedef struct Release { +struct Release { std::string title; std::string body; std::string tag; @@ -39,7 +39,7 @@ typedef struct Release { static std::optional FromJson(const std::string_view& json, const std::string &host, const std::string& repo); static std::vector ListFromJson(const nlohmann::json &json, const std::string &host, const std::string &repo); static std::vector ListFromJson(const std::string_view &json, const std::string &host, const std::string &repo); -} Release; +}; // Make a request via httplib, and return the response body if applicable. std::optional MakeRequest(const std::string &url, const std::string &path);