From fa4e7c699243dae407a09fc3c54e7a0a822329b5 Mon Sep 17 00:00:00 2001 From: PavelBARABANOV Date: Wed, 16 Sep 2026 01:42:37 +0200 Subject: [PATCH] [vk_texture_cache] drop depth comparison sampler fallback (#4408) - [x] I have read and followed the [Contribution Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions). - [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md) - [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md) to the best of my ability. ------------------- This fixes the flashlight in Alan Wake. Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4408 Reviewed-by: MaranBr Reviewed-by: CamilleLaVey --- src/video_core/renderer_vulkan/vk_texture_cache.cpp | 5 ----- src/video_core/renderer_vulkan/vk_texture_cache.h | 1 - 2 files changed, 6 deletions(-) diff --git a/src/video_core/renderer_vulkan/vk_texture_cache.cpp b/src/video_core/renderer_vulkan/vk_texture_cache.cpp index c3f56408b5..bc2e82acae 100644 --- a/src/video_core/renderer_vulkan/vk_texture_cache.cpp +++ b/src/video_core/renderer_vulkan/vk_texture_cache.cpp @@ -2850,8 +2850,6 @@ Sampler::VariantKey Sampler::MakeKey(const ImageView& image_view, bool is_depth) VariantKey key{}; key.reduce_anisotropy = has_added_anisotropy && !image_view.SupportsAnisotropy(); key.force_nearest = has_linear_filtering && IsPixelFormatInteger(image_view.format); - key.drop_depth_comparison = - is_depth && has_depth_comparison && !image_view.SupportsDepthComparison(); key.drop_reduction = has_minmax_reduction && !image_view.SupportsMinmaxFilter(); key.drop_custom_border = has_custom_border_colors && image_view.RequiresBorderColorFormat(); key.srgb_border = has_srgb_border_color && IsPixelFormatSRGB(image_view.format); @@ -2929,9 +2927,6 @@ VkSampler Sampler::Emplace(VariantKey key) { create_info.anisotropyEnable = static_cast(default_anisotropy > 1.0f); create_info.maxAnisotropy = default_anisotropy; } - if (key.drop_depth_comparison) { - create_info.compareEnable = VK_FALSE; - } if (!custom_border) { create_info.borderColor = ConvertBorderColor(color); } diff --git a/src/video_core/renderer_vulkan/vk_texture_cache.h b/src/video_core/renderer_vulkan/vk_texture_cache.h index 68bf2af991..2e9736f707 100644 --- a/src/video_core/renderer_vulkan/vk_texture_cache.h +++ b/src/video_core/renderer_vulkan/vk_texture_cache.h @@ -536,7 +536,6 @@ private: struct VariantKey { bool reduce_anisotropy; bool force_nearest; - bool drop_depth_comparison; bool drop_reduction; bool drop_custom_border; bool srgb_border;