lizzie
395613b01f
[common/logging] Simplify logging logic and fix issues when logging before system is created ( #3688 )
...
- our logging code was bigger than spdlog itself, why???? just keep it simple
- fix issues when logging before logging system is even started
- removes the "initialized logging twice" issue
- removes uneeded indirection in file logging
- uses direct formatting instead of jumping hoopla-around the fmt::format() ressult
- code duplication and dead code removal as usual
I did explore dup2() but I think it's not worth the hassle
I did try `fwopen()` but it's better if things are just kept as-is.
there is a lot of noise because I removed a bunch of redundant files on logging and just put everything in one file
now normally this wouldn't be a good idea, however consider: the complexity of logging; it's less than 500 lines... does it really need a whole subsystem?!?!?! ITS JUST LOGGING
Signed-off-by: lizzie <lizzie@eden-emu.dev >
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/3688
Reviewed-by: crueter <crueter@eden-emu.dev >
Reviewed-by: DraVee <chimera@dravee.dev >
Reviewed-by: CamilleLaVey <camillelavey99@gmail.com >
Co-authored-by: lizzie <lizzie@eden-emu.dev >
Co-committed-by: lizzie <lizzie@eden-emu.dev >
2026-03-12 18:29:15 +01:00
Maufeat
28a78d76fe
[audio] add splitter_size ( #3477 )
...
Thanks to: https://git.ryujinx.app/ryubing/ryujinx/-/merge_requests/257
Credits to Coxxs and his friend.
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/3477
Reviewed-by: MaranBr <maranbr@eden-emu.dev >
Reviewed-by: DraVee <dravee@eden-emu.dev >
Reviewed-by: CamilleLaVey <camillelavey99@gmail.com >
Co-authored-by: Maufeat <sahyno1996@gmail.com >
Co-committed-by: Maufeat <sahyno1996@gmail.com >
2026-02-11 01:13:09 +01:00
MaranBr
55646657e1
[audio_core] Better biquad filter logic ( #3235 )
...
This removes all redundant code and improves the logic of the biquad filter.
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/3235
Reviewed-by: Maufeat <sahyno1996@gmail.com >
Co-authored-by: MaranBr <maranbr@outlook.com >
Co-committed-by: MaranBr <maranbr@outlook.com >
2025-12-31 14:15:06 +01:00
MaranBr
b95c4d2d5d
[audio_core] Fix broken biquad effect ( #3225 )
...
This fixes the broken biquad effect.
Thanks to Forrest Mark X for showing us where the problem was occurring in the code.
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/3225
Reviewed-by: Maufeat <sahyno1996@gmail.com >
Reviewed-by: DraVee <dravee@eden-emu.dev >
Co-authored-by: MaranBr <maranbr@outlook.com >
Co-committed-by: MaranBr <maranbr@outlook.com >
2025-12-29 20:24:57 +01:00
Maufeat
06b83a58a6
[audio] correct biquad filter v2 parameters ( #3142 )
...
We had the same struct for v1 and v2 - this was tested only with MP4, should output correct sounds now and boot it.
Co-authored-by: MaranBr <maranbr@outlook.com >
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/3142
Reviewed-by: MaranBr <maranbr@eden-emu.dev >
Reviewed-by: crueter <crueter@eden-emu.dev >
Co-authored-by: Maufeat <sahyno1996@gmail.com >
Co-committed-by: Maufeat <sahyno1996@gmail.com >
2025-12-13 19:44:41 +01:00
lizzie
d1ac5b2e50
[qt_common, core, audio] remove duplicate string literal definitions, inline SystemManager::threadfunc, increase latency of audio shutdown ( #3030 )
...
Very small code cleanup, also remove `[[unlikely]]` because it doesn't matter + increase latency of audio render when shutting down
Signed-off-by: lizzie lizzie@eden-emu.dev
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/3030
Reviewed-by: Caio Oliveira <caiooliveirafarias0@gmail.com >
Reviewed-by: crueter <crueter@eden-emu.dev >
Co-authored-by: lizzie <lizzie@eden-emu.dev >
Co-committed-by: lizzie <lizzie@eden-emu.dev >
2025-11-17 22:37:45 +01:00
MaranBr
576c4e5f77
[audio_core] Fix audio reverb effect acording to specs ( #2976 )
...
This fixes the audio reverb issue acording to specs. Known for affecting The Legend of Zelda: Echoes of Wisdom.
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/2976
Reviewed-by: CamilleLaVey <camillelavey99@gmail.com >
Reviewed-by: Caio Oliveira <caiooliveirafarias0@gmail.com >
Co-authored-by: MaranBr <maranbr@outlook.com >
Co-committed-by: MaranBr <maranbr@outlook.com >
2025-11-08 03:50:51 +01:00
lizzie
992bae4e2a
[common] replace Common::BitCast with libc++ provided one ( #2774 )
...
Signed-off-by: lizzie <lizzie@eden-emu.dev >
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/2774
Reviewed-by: MaranBr <maranbr@eden-emu.dev >
Reviewed-by: crueter <crueter@eden-emu.dev >
Co-authored-by: lizzie <lizzie@eden-emu.dev >
Co-committed-by: lizzie <lizzie@eden-emu.dev >
2025-10-22 02:56:28 +02:00
unknown
a3ef2cc183
[audio_core/hid] Audio REV12+15 support + HID fixes ( #2719 )
...
This fixes newer updates / games.
Implements partial audio rev15, rev13, rev12 and HID issues on SDK20+ games.
Credits to LotP (Ryubing) and Zephyron (Citron) for their research and implementation.
Co-authored-by: Zephyron <zephyron@citron-emu.org >
Co-authored-by: Shinmegumi <shinmegumi@eden-emu.dev >
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/2719
Reviewed-by: MaranBr <maranbr@eden-emu.dev >
Reviewed-by: CamilleLaVey <camillelavey99@gmail.com >
Co-authored-by: unknown <sahyno1996@gmail.com >
Co-committed-by: unknown <sahyno1996@gmail.com >
2025-10-12 17:03:14 +02:00
MaranBr
1a5b3fb239
[audio_core] Fix audio reverb effect ( #2646 )
...
This fixes the audio reverb effect that was causing loud noise in some games and on some platforms.
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/2646
Co-authored-by: MaranBr <maranbr@outlook.com >
Co-committed-by: MaranBr <maranbr@outlook.com >
2025-10-02 01:30:05 +02:00
MaranBr
9a098441de
[audio_core] Fix audio issue in The Legend of Zelda - Echoes of Wisdom ( #2594 )
...
This fixes the audio issue in The Legend of Zelda - Echoes of Wisdom on Windows.
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/2594
Reviewed-by: CamilleLaVey <camillelavey99@gmail.com >
Co-authored-by: MaranBr <maranbr@outlook.com >
Co-committed-by: MaranBr <maranbr@outlook.com >
2025-10-01 05:33:37 +02:00
lizzie
f19bbda517
[common] remove ranges polyfill ( #2546 )
...
Signed-off-by: lizzie <lizzie@eden-emu.dev >
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/2546
Reviewed-by: MaranBr <maranbr@eden-emu.dev >
Reviewed-by: crueter <crueter@eden-emu.dev >
Co-authored-by: lizzie <lizzie@eden-emu.dev >
Co-committed-by: lizzie <lizzie@eden-emu.dev >
2025-09-24 19:29:48 +02:00
lizzie
191e4c75a1
[meta] fix license headers ( #2547 )
...
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/2547
Reviewed-by: MaranBr <maranbr@eden-emu.dev >
Co-authored-by: lizzie <lizzie@eden-emu.dev >
Co-committed-by: lizzie <lizzie@eden-emu.dev >
2025-09-21 21:58:59 +02:00
lizzie
9d2681ecc9
[cmake] enable clang-cl and WoA builds ( #348 )
...
Compilation and CMake fixes for both Windows on ARM and clang-cl, meaning Windows can now be built on both MSVC and clang on both amd64 and aarch64.
Compiling on clang is *dramatically* faster so this should be useful for CI.
Co-authored-by: crueter <crueter@eden-emu.dev >
Co-authored-by: crueter <crueter@crueter.xyz >
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/348
Reviewed-by: CamilleLaVey <camillelavey99@gmail.com >
Reviewed-by: crueter <crueter@eden-emu.dev >
Co-authored-by: lizzie <lizzie@eden-emu.dev >
Co-committed-by: lizzie <lizzie@eden-emu.dev >
2025-09-09 20:47:49 +02:00
crueter
f1e74f6855
[meta] remove MicroProfile ( #185 )
...
Signed-off-by: crueter <crueter@eden-emu.dev >
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/185
Reviewed-by: Lizzie <lizzie@eden-emu.dev >
2025-08-06 07:48:11 +02:00
edendev
20f2e4dffd
Revert "Add more audio logging to pinpoint issues better"
...
This reverts commit b75251742c .
2025-04-30 18:21:01 -07:00
edendev
b75251742c
Add more audio logging to pinpoint issues better
2025-04-30 18:01:26 -07:00
Liam
58d8db6ac7
audio: format
2024-02-20 22:51:39 -05:00
Liam
a898ae4f7d
audio: rewrite IAudioDevice
2024-02-20 22:15:38 -05:00
Liam
99b848b523
audio: rewrite IAudioRendererManager
2024-02-20 22:15:37 -05:00
Kelebek1
760d085dbe
Use the input process handle to get the correct application's memory
2024-01-28 18:51:43 +00:00
Fernando Sahmkow
b206089ea7
Core: Clang format and other small issues.
2024-01-18 21:12:30 -05:00
Fernando Sahmkow
9db159da71
SMMU: Initial adaptation to video_core.
2024-01-18 21:12:30 -05:00
Viktor Szépe
8f8a15827f
Fix more typos
2024-01-15 23:26:53 +00:00
Liam
445d504f94
ci: fix new codespell errors
2023-10-02 18:03:05 -04:00
Kelebek1
ae492d8a74
Do not consider voice commands in time estimation, fix adpcm estimate
2023-09-18 10:38:14 +01:00
liamwhite
80c47115e6
Merge pull request #11465 from Kelebek1/skip_remaining_reset
...
[Audio] Do not reset the remaining command count each time
2023-09-10 13:40:32 -04:00
Kelebek1
0d50c09352
Fix data source version 1 command looping
2023-09-08 15:03:21 +01:00
Kelebek1
4ef3915a8c
Do not reset the command buffer command count each time
2023-09-07 20:53:48 +01:00
Kelebek1
de326e42bb
Rework ADSP into a wrapper for apps
2023-09-04 17:12:16 +01:00
Kelebek1
007b1e9652
Fix node id index in DropVoices
2023-08-28 10:35:30 +01:00
Kelebek1
42638691b5
Use spans over guest memory where possible instead of copying data.
2023-07-02 23:09:48 +01:00
Kelebek1
c7430e51e3
Remove memory allocations in some hot paths
2023-06-22 08:05:10 +01:00
Morph
2856fadaa0
core_timing: Use CNTPCT as the guest CPU tick
...
Previously, we were mixing the raw CPU frequency and CNTFRQ.
The raw CPU frequency (1020 MHz) should've never been used as CNTPCT (whose frequency is CNTFRQ) is the only counter available.
2023-06-07 21:44:42 -04:00
Liam
16bd50f9b4
audio_renderer: resolve adsp thread deadlock shutdown
2023-06-04 13:00:10 -04:00
Kelebek1
ba0d258a3f
Smooth out the DSP callback by adding a 5ms wait time limit
2023-05-18 13:03:32 +01:00
Kelebek1
967e5b2873
Wait for the terminate event before destroying a system instance
2023-05-01 00:27:12 +01:00
bunnei
831a0614ea
Merge pull request #9969 from bylaws/master
...
Audio synchronisation improvements
2023-04-01 14:34:59 -07:00
Billy Laws
91d14c0022
Run clang-format
2023-03-27 22:01:41 +01:00
Billy Laws
d3f0149af2
audio: Wait for samples on the emulated DSP side to avoid desyncs
...
Waiting on the host side is inaccurate and leads to desyncs in the event of the sink missing a deadline that require stalls to fix. By waiting for the sink to have space before even starting rendering such desyncs can be avoided.
2023-03-27 21:34:28 +01:00
Billy Laws
7e7ad78aaf
audio: Interpolate system manager sample count using host sink sample info
...
This avoids the need to stall if the host sink sporadically misses the deadline, in such a case the previous implementation would report them samples as being played on-time, causing the guest to send more samples and leading to a gradual buildup.
2023-03-26 22:48:57 +01:00
Liam
6eaef51cf2
memory: rename global memory references to application memory
2023-03-23 20:28:47 -04:00
Liam
5be8a74b0c
general: fix spelling mistakes
2023-03-12 11:33:01 -04:00
liamwhite
2b8955aaa4
Merge pull request #9917 from Morph1984/the-real-time
...
native_clock: Re-adjust the RDTSC frequency to its real frequency
2023-03-10 13:55:11 -05:00
Morph
ddb330121a
core: Promote CPU/GPU threads to time critical
...
And also demote Audren and CoreTiming to High thread priority.
2023-03-07 21:17:46 -05:00
Liam
ea36f70e02
hle: rename legacy errors to Results
2023-03-06 20:58:42 -05:00
Kelebek1
ed68646fa7
Fix a bug with the Reverb command in reading from the pre_delay line.
2023-03-02 06:00:55 +00:00
bunnei
bba16a8016
Merge pull request #9769 from Kelebek1/audio_oob
...
[audio_core] Fix depop prepare
2023-02-16 12:26:23 -08:00
liamwhite
207fdfe57d
Merge pull request #9796 from liamwhite/current
...
general: rename CurrentProcess to ApplicationProcess
2023-02-15 17:42:45 -05:00
arades79
60a68839ee
remove static from pointer sized or smaller types for aesthetics, change constexpr static to static constexpr for consistency
...
Signed-off-by: arades79 <scravers@protonmail.com >
2023-02-14 12:35:39 -05:00