Compare commits

...

9 Commits

Author SHA1 Message Date
CamilleLaVey 360b6542a9 Revert "[GPU] Change GOB processing with inline upload/download functions" 2026-07-03 01:57:46 +02:00
CamilleLaVey 29e3a3a780 [GPU] Change GOB processing with inline upload/download functions 2026-07-03 01:57:46 +02:00
CamilleLaVey 1ec388c01b Revert 2026-07-03 01:57:46 +02:00
CamilleLaVey 54ce017b10 [GPU] Added flush helper to detect when FlusRegion must be flushed 2026-07-03 01:57:46 +02:00
lizzie 672432372d no relaxed flush then 2026-07-03 01:57:46 +02:00
lizzie 7e30579a7a relaxed flush 2026-07-03 01:57:46 +02:00
lizzie 01a616704b force stronger read 2026-07-03 01:57:46 +02:00
lizzie 07031708ce fx 2026-07-03 01:57:46 +02:00
lizzie 600c8b5ab9 [vk, nce] force flush when NCE fault on rasterizer area
Signed-off-by: lizzie <lizzie@eden-emu.dev>
2026-07-03 01:57:46 +02:00
3 changed files with 19 additions and 22 deletions
+1 -2
View File
@@ -162,8 +162,7 @@ bool ArmNce::HandleGuestAccessFault(GuestContext* guest_ctx, void* raw_info, voi
// Try to handle an invalid access.
// TODO: handle accesses which split a page?
const Common::ProcessAddress addr =
(reinterpret_cast<u64>(info->si_addr) & ~Memory::YUZU_PAGEMASK);
const Common::ProcessAddress addr = u64(info->si_addr) & ~Memory::YUZU_PAGEMASK;
auto& memory = guest_ctx->parent->m_running_thread->GetOwnerProcess()->GetMemory();
if (memory.InvalidateNCE(addr, Memory::YUZU_PAGESIZE)) {
// We handled the access successfully and are returning to guest code.
+17 -19
View File
@@ -737,10 +737,9 @@ struct Memory::Impl {
PAddr last_address;
};
void InvalidateGPUMemory(u8* p, size_t size) {
void InvalidateGPUMemory(u8* p, size_t size, bool flush) {
constexpr size_t sys_core = Core::Hardware::NUM_CPU_CORES - 1;
const size_t core = (std::min)(system.GetCurrentHostThreadID(),
sys_core); // any other calls threads go to syscore.
const size_t core = (std::min)(system.GetCurrentHostThreadID(), sys_core); // any other calls threads go to syscore.
if (!gpu_device_memory) [[unlikely]] {
gpu_device_memory = &system.Host1x().MemoryManager();
}
@@ -754,8 +753,12 @@ struct Memory::Impl {
}
};
auto& gpu = system.GPU();
gpu_device_memory->ApplyOpOnPointer(
p, scratch_buffers[core], [&](DAddr address) { gpu.InvalidateRegion(address, size); });
gpu_device_memory->ApplyOpOnPointer(p, scratch_buffers[core], [&](DAddr addr) {
if (flush) {
void(gpu.OnCPURead(addr, size));
}
gpu.InvalidateRegion(addr, size);
});
}
Core::System& system;
@@ -959,27 +962,22 @@ void Memory::MarkRegionDebug(Common::ProcessAddress vaddr, u64 size, bool debug)
}
bool Memory::InvalidateNCE(Common::ProcessAddress vaddr, size_t size) {
[[maybe_unused]] bool mapped = true;
[[maybe_unused]] bool rasterizer = false;
u8* const ptr = impl->GetPointerImpl(
GetInteger(vaddr),
[&] {
LOG_ERROR(HW_Memory, "Unmapped InvalidateNCE for {} bytes @ {:#x}", size,
GetInteger(vaddr));
mapped = false;
},
[&] { rasterizer = true; });
bool mapped = true;
bool rasterizer = false;
u8* const ptr = impl->GetPointerImpl(GetInteger(vaddr), [&] {
LOG_ERROR(HW_Memory, "Unmapped InvalidateNCE for {} bytes @ {:#x}", size, GetInteger(vaddr));
mapped = false;
}, [&] {
rasterizer = true;
});
if (rasterizer) {
impl->InvalidateGPUMemory(ptr, size);
impl->InvalidateGPUMemory(ptr, size, true);
}
#ifdef __ANDROID__
if (!rasterizer && mapped) {
impl->host_buffer->DeferredMapSeparateHeap(GetInteger(vaddr));
}
#endif
return mapped && ptr != nullptr;
}
+1 -1
View File
@@ -1,4 +1,4 @@
// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project
// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
// SPDX-License-Identifier: GPL-3.0-or-later
// SPDX-FileCopyrightText: Copyright 2018 yuzu Emulator Project