Compare commits

...

1 Commits

Author SHA1 Message Date
lizzie b65ad138e3 [qt, input_common] allow to invert gyro controls on all 3 dimensions
Signed-off-by: lizzie <lizzie@eden-emu.dev>
2026-03-06 09:44:19 +00:00
2 changed files with 70 additions and 36 deletions
+36 -12
View File
@@ -1,3 +1,6 @@
// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
// SPDX-License-Identifier: GPL-3.0-or-later
// SPDX-FileCopyrightText: Copyright 2021 yuzu Emulator Project // SPDX-FileCopyrightText: Copyright 2021 yuzu Emulator Project
// SPDX-License-Identifier: GPL-2.0-or-later // SPDX-License-Identifier: GPL-2.0-or-later
@@ -556,10 +559,15 @@ private:
class InputFromMotion final : public Common::Input::InputDevice { class InputFromMotion final : public Common::Input::InputDevice {
public: public:
explicit InputFromMotion(PadIdentifier identifier_, int motion_sensor_, float gyro_threshold_, explicit InputFromMotion(PadIdentifier identifier_, int motion_sensor_, float gyro_threshold_, bool invert_x_, bool invert_y_, bool invert_z_, InputEngine* input_engine_)
InputEngine* input_engine_) : identifier(identifier_)
: identifier(identifier_), motion_sensor(motion_sensor_), gyro_threshold(gyro_threshold_), , motion_sensor(motion_sensor_)
input_engine(input_engine_) { , gyro_threshold(gyro_threshold_)
, input_engine(input_engine_)
, invert_x{invert_x_}
, invert_y{invert_y_}
, invert_z{invert_z_}
{
UpdateCallback engine_callback{[this]() { OnChange(); }}; UpdateCallback engine_callback{[this]() { OnChange(); }};
const InputIdentifier input_identifier{ const InputIdentifier input_identifier{
.identifier = identifier, .identifier = identifier,
@@ -575,7 +583,19 @@ public:
} }
Common::Input::MotionStatus GetStatus() const { Common::Input::MotionStatus GetStatus() const {
const auto basic_motion = input_engine->GetMotion(identifier, motion_sensor); auto basic_motion = input_engine->GetMotion(identifier, motion_sensor);
if (invert_x) {
basic_motion.accel_x = -basic_motion.accel_x;
basic_motion.gyro_x = -basic_motion.gyro_x;
}
if (invert_y) {
basic_motion.accel_y = -basic_motion.accel_y;
basic_motion.gyro_y = -basic_motion.gyro_y;
}
if (invert_z) {
basic_motion.accel_z = -basic_motion.accel_z;
basic_motion.gyro_z = -basic_motion.gyro_z;
}
Common::Input::MotionStatus status{}; Common::Input::MotionStatus status{};
const Common::Input::AnalogProperties properties = { const Common::Input::AnalogProperties properties = {
.deadzone = 0.0f, .deadzone = 0.0f,
@@ -608,6 +628,9 @@ private:
const float gyro_threshold; const float gyro_threshold;
int callback_key; int callback_key;
InputEngine* input_engine; InputEngine* input_engine;
bool invert_x : 1;
bool invert_y : 1;
bool invert_z : 1;
}; };
class InputFromAxisMotion final : public Common::Input::InputDevice { class InputFromAxisMotion final : public Common::Input::InputDevice {
@@ -1066,13 +1089,15 @@ std::unique_ptr<Common::Input::InputDevice> InputFactory::CreateMotionDevice(
.pad = static_cast<std::size_t>(params.Get("pad", 0)), .pad = static_cast<std::size_t>(params.Get("pad", 0)),
}; };
auto const invert_x = params.Get("invert_x", "+") == "-";
auto const invert_y = params.Get("invert_y", "+") != "+";
auto const invert_z = params.Get("invert_z", "+") != "+";
if (params.Has("motion")) { if (params.Has("motion")) {
const auto motion_sensor = params.Get("motion", 0); const auto motion_sensor = params.Get("motion", 0);
const auto gyro_threshold = params.Get("threshold", 0.007f); const auto gyro_threshold = params.Get("threshold", 0.007f);
input_engine->PreSetController(identifier); input_engine->PreSetController(identifier);
input_engine->PreSetMotion(identifier, motion_sensor); input_engine->PreSetMotion(identifier, motion_sensor);
return std::make_unique<InputFromMotion>(identifier, motion_sensor, gyro_threshold, return std::make_unique<InputFromMotion>(identifier, motion_sensor, gyro_threshold, invert_x, invert_y, invert_z, input_engine.get());
input_engine.get());
} }
const auto deadzone = std::clamp(params.Get("deadzone", 0.15f), 0.0f, 1.0f); const auto deadzone = std::clamp(params.Get("deadzone", 0.15f), 0.0f, 1.0f);
@@ -1085,7 +1110,7 @@ std::unique_ptr<Common::Input::InputDevice> InputFactory::CreateMotionDevice(
.range = range, .range = range,
.threshold = threshold, .threshold = threshold,
.offset = std::clamp(params.Get("offset_x", 0.0f), -1.0f, 1.0f), .offset = std::clamp(params.Get("offset_x", 0.0f), -1.0f, 1.0f),
.inverted = params.Get("invert_x", "+") == "-", .inverted = invert_x,
}; };
const auto axis_y = params.Get("axis_y", 1); const auto axis_y = params.Get("axis_y", 1);
@@ -1094,7 +1119,7 @@ std::unique_ptr<Common::Input::InputDevice> InputFactory::CreateMotionDevice(
.range = range, .range = range,
.threshold = threshold, .threshold = threshold,
.offset = std::clamp(params.Get("offset_y", 0.0f), -1.0f, 1.0f), .offset = std::clamp(params.Get("offset_y", 0.0f), -1.0f, 1.0f),
.inverted = params.Get("invert_y", "+") != "+", .inverted = invert_y,
}; };
const auto axis_z = params.Get("axis_z", 1); const auto axis_z = params.Get("axis_z", 1);
@@ -1103,14 +1128,13 @@ std::unique_ptr<Common::Input::InputDevice> InputFactory::CreateMotionDevice(
.range = range, .range = range,
.threshold = threshold, .threshold = threshold,
.offset = std::clamp(params.Get("offset_z", 0.0f), -1.0f, 1.0f), .offset = std::clamp(params.Get("offset_z", 0.0f), -1.0f, 1.0f),
.inverted = params.Get("invert_z", "+") != "+", .inverted = invert_z,
}; };
input_engine->PreSetController(identifier); input_engine->PreSetController(identifier);
input_engine->PreSetAxis(identifier, axis_x); input_engine->PreSetAxis(identifier, axis_x);
input_engine->PreSetAxis(identifier, axis_y); input_engine->PreSetAxis(identifier, axis_y);
input_engine->PreSetAxis(identifier, axis_z); input_engine->PreSetAxis(identifier, axis_z);
return std::make_unique<InputFromAxisMotion>(identifier, axis_x, axis_y, axis_z, properties_x, return std::make_unique<InputFromAxisMotion>(identifier, axis_x, axis_y, axis_z, properties_x, properties_y, properties_z, input_engine.get());
properties_y, properties_z, input_engine.get());
} }
std::unique_ptr<Common::Input::InputDevice> InputFactory::CreateCameraDevice( std::unique_ptr<Common::Input::InputDevice> InputFactory::CreateCameraDevice(
@@ -1,4 +1,4 @@
// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project // SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
// SPDX-License-Identifier: GPL-3.0-or-later // SPDX-License-Identifier: GPL-3.0-or-later
// SPDX-FileCopyrightText: 2016 Citra Emulator Project // SPDX-FileCopyrightText: 2016 Citra Emulator Project
@@ -465,30 +465,40 @@ ConfigureInputPlayer::ConfigureInputPlayer(QWidget* parent, std::size_t player_i
button->setContextMenuPolicy(Qt::CustomContextMenu); button->setContextMenuPolicy(Qt::CustomContextMenu);
connect(button, &QPushButton::customContextMenuRequested, connect(button, &QPushButton::customContextMenuRequested, [=, this](const QPoint& menu_location) {
[=, this](const QPoint& menu_location) { QMenu context_menu;
QMenu context_menu; Common::ParamPackage param = emulated_controller->GetMotionParam(motion_id);
Common::ParamPackage param = emulated_controller->GetMotionParam(motion_id); context_menu.addAction(tr("Clear"), [&] {
context_menu.addAction(tr("Clear"), [&] { emulated_controller->SetMotionParam(motion_id, {});
emulated_controller->SetMotionParam(motion_id, {}); motion_map[motion_id]->setText(tr("[not set]"));
motion_map[motion_id]->setText(tr("[not set]")); });
}); if (param.Has("motion")) {
if (param.Has("motion")) { context_menu.addAction(tr("Set gyro threshold"), [&] {
context_menu.addAction(tr("Set gyro threshold"), [&] { const int gyro_threshold = int(param.Get("threshold", 0.007f) * 1000.0f);
const int gyro_threshold = const int new_threshold = QInputDialog::getInt(
static_cast<int>(param.Get("threshold", 0.007f) * 1000.0f); this, tr("Set threshold"), tr("Choose a value between 0% and 100%"),
const int new_threshold = QInputDialog::getInt( gyro_threshold, 0, 100);
this, tr("Set threshold"), tr("Choose a value between 0% and 100%"), param.Set("threshold", new_threshold / 1000.0f);
gyro_threshold, 0, 100); emulated_controller->SetMotionParam(motion_id, param);
param.Set("threshold", new_threshold / 1000.0f);
emulated_controller->SetMotionParam(motion_id, param);
});
context_menu.addAction(tr("Calibrate sensor"), [&] {
emulated_controller->StartMotionCalibration();
});
}
context_menu.exec(motion_map[motion_id]->mapToGlobal(menu_location));
}); });
context_menu.addAction(tr("Invert X"), [&] {
param.Set("invert_x", param.Get("invert_x", "+") == "-" ? "+" : "-");
emulated_controller->SetMotionParam(motion_id, param);
});
context_menu.addAction(tr("Invert Y"), [&] {
param.Set("invert_y", param.Get("invert_y", "+") == "-" ? "+" : "-");
emulated_controller->SetMotionParam(motion_id, param);
});
context_menu.addAction(tr("Invert Z"), [&] {
param.Set("invert_z", param.Get("invert_z", "+") == "-" ? "+" : "-");
emulated_controller->SetMotionParam(motion_id, param);
});
context_menu.addAction(tr("Calibrate sensor"), [&] {
emulated_controller->StartMotionCalibration();
});
}
context_menu.exec(motion_map[motion_id]->mapToGlobal(menu_location));
});
} }
connect(ui->sliderZLThreshold, &QSlider::valueChanged, [=, this] { connect(ui->sliderZLThreshold, &QSlider::valueChanged, [=, this] {