mirror of
https://git.eden-emu.dev/eden-emu/eden.git
synced 2026-09-29 03:48:40 +00:00
dbeb73ee01
- [x] I have read and followed the [Contribution Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions). - [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md) - [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md) to the best of my ability. ------------------- Aimed to fix two known UE5 crashes: Kepler uploads and Maxwell macros, both caused by CPU/GPU races due dirty tracking issues. Kepler ComputeInline: preserved dirty tracking across dma continuations and async readback. Maxwell macros: preserved gpu owned subranges during page granular cpu uploads. DiscardWrite: stopped clearing neighboring macro arguments by rounding up ranges. DMA Step: improved continuation aware dirty sampling. To the Ender Magnolia crew (maybe 1 or 2 persons): This will fix the dash crash, and the random / shackled beast vaper crashes. There are some more UE5 issues to go next. Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4473 Reviewed-by: lizzie <lizzie@eden-emu.dev> Reviewed-by: MaranBr <maranbr@eden-emu.dev>
211 lines
8.1 KiB
C++
211 lines
8.1 KiB
C++
// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
|
|
// SPDX-License-Identifier: GPL-3.0-or-later
|
|
|
|
// SPDX-FileCopyrightText: Copyright 2021 yuzu Emulator Project
|
|
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
#include "common/settings.h"
|
|
#include "core/core.h"
|
|
#include "video_core/dma_pusher.h"
|
|
#include "video_core/engines/maxwell_3d.h"
|
|
#include "video_core/gpu.h"
|
|
#include "video_core/guest_memory.h"
|
|
#include "video_core/memory_manager.h"
|
|
#include "video_core/rasterizer_interface.h"
|
|
|
|
namespace Tegra {
|
|
|
|
constexpr u32 MacroRegistersStart = 0xE00;
|
|
constexpr u32 ComputeInline = 0x6D;
|
|
|
|
DmaPusher::DmaPusher(Core::System& system_, MemoryManager& memory_manager_, Control::ChannelState& channel_state_)
|
|
: system{system_}
|
|
, memory_manager{memory_manager_}
|
|
, channel_state{channel_state_}
|
|
, signal_sync{false}
|
|
, synced{false}
|
|
{}
|
|
|
|
DmaPusher::~DmaPusher() = default;
|
|
|
|
void DmaPusher::DispatchCalls() {
|
|
dma_pushbuffer_subindex = 0;
|
|
dma_state.is_last_call = true;
|
|
while (system.IsPoweredOn()) {
|
|
if (!Step()) {
|
|
break;
|
|
}
|
|
}
|
|
system.GPU().FlushCommands();
|
|
system.GPU().OnCommandListEnd();
|
|
}
|
|
|
|
bool DmaPusher::Step() {
|
|
if (!ib_enable || dma_pushbuffer.empty()) {
|
|
return false;
|
|
}
|
|
|
|
CommandList& command_list = dma_pushbuffer.front();
|
|
|
|
const size_t prefetch_size = command_list.prefetch_command_list.size();
|
|
const size_t command_list_size = command_list.command_lists.size();
|
|
|
|
if (prefetch_size == 0 && command_list_size == 0) {
|
|
dma_pushbuffer.pop();
|
|
dma_pushbuffer_subindex = 0;
|
|
return true;
|
|
}
|
|
|
|
if (prefetch_size > 0) {
|
|
ProcessCommands(command_list.prefetch_command_list);
|
|
dma_pushbuffer.pop();
|
|
return true;
|
|
}
|
|
|
|
auto& current_command = command_list.command_lists[dma_pushbuffer_subindex];
|
|
const CommandListHeader& header = current_command;
|
|
dma_state.dma_get = header.addr;
|
|
|
|
if (signal_sync && !synced) {
|
|
std::unique_lock lk(sync_mutex);
|
|
sync_cv.wait(lk, [this]() { return synced; });
|
|
signal_sync = false;
|
|
synced = false;
|
|
}
|
|
|
|
if (header.size > 0) {
|
|
if (subchannels[dma_state.subchannel] && dma_state.method_count) {
|
|
const auto engine = subchannel_type[dma_state.subchannel];
|
|
const bool kepler_payload = engine == Engines::EngineTypes::KeplerCompute && dma_state.method == ComputeInline && dma_state.non_incrementing;
|
|
const bool macro_payload = engine == Engines::EngineTypes::Maxwell3D && dma_state.method >= MacroRegistersStart;
|
|
if (kepler_payload || macro_payload) {
|
|
const size_t words = std::min<size_t>(dma_state.method_count, header.size);
|
|
subchannels[dma_state.subchannel]->current_dirty = memory_manager.IsMemoryDirty(dma_state.dma_get, words * sizeof(u32));
|
|
}
|
|
}
|
|
const bool use_safe = Settings::IsDMALevelDefault() ? Settings::IsGPULevelHigh() : Settings::IsDMALevelSafe();
|
|
if (use_safe) {
|
|
Tegra::Memory::GpuGuestMemory<Tegra::CommandHeader, Tegra::Memory::GuestMemoryFlags::SafeRead>headers(memory_manager, dma_state.dma_get, header.size, &command_headers);
|
|
ProcessCommands(headers);
|
|
} else {
|
|
Tegra::Memory::GpuGuestMemory<Tegra::CommandHeader, Tegra::Memory::GuestMemoryFlags::UnsafeRead>headers(memory_manager, dma_state.dma_get, header.size, &command_headers);
|
|
ProcessCommands(headers);
|
|
}
|
|
}
|
|
|
|
if (++dma_pushbuffer_subindex >= command_list_size) {
|
|
dma_pushbuffer.pop();
|
|
dma_pushbuffer_subindex = 0;
|
|
} else {
|
|
signal_sync = command_list.command_lists[dma_pushbuffer_subindex].sync && Settings::values.sync_memory_operations.GetValue();
|
|
}
|
|
|
|
if (signal_sync) {
|
|
rasterizer->SignalFence([this]() {
|
|
std::scoped_lock lk(sync_mutex);
|
|
synced = true;
|
|
sync_cv.notify_all();
|
|
});
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
void DmaPusher::ProcessCommands(std::span<const CommandHeader> commands) {
|
|
for (size_t index = 0; index < commands.size();) {
|
|
// Data word of methods command
|
|
if (dma_state.method_count && dma_state.non_incrementing) {
|
|
auto const& command_header = commands[index]; //must ref (MUltiMethod re)
|
|
dma_state.dma_word_offset = u32(index * sizeof(u32));
|
|
const u32 max_write = u32(std::min<std::size_t>(index + dma_state.method_count, commands.size()) - index);
|
|
CallMultiMethod(&command_header.argument, max_write);
|
|
dma_state.method_count -= max_write;
|
|
dma_state.is_last_call = true;
|
|
index += max_write;
|
|
} else if (dma_state.method_count) {
|
|
auto const command_header = commands[index]; //can copy
|
|
dma_state.dma_word_offset = u32(index * sizeof(u32));
|
|
dma_state.is_last_call = dma_state.method_count <= 1;
|
|
CallMethod(command_header.argument);
|
|
dma_state.method += !dma_state.non_incrementing ? 1 : 0;
|
|
dma_state.non_incrementing |= dma_increment_once;
|
|
dma_state.method_count--;
|
|
index++;
|
|
} else {
|
|
auto const command_header = commands[index]; //can copy
|
|
// No command active - this is the first word of a new one
|
|
switch (command_header.mode) {
|
|
case SubmissionMode::Increasing:
|
|
SetState(command_header);
|
|
dma_state.non_incrementing = false;
|
|
dma_increment_once = false;
|
|
break;
|
|
case SubmissionMode::NonIncreasing:
|
|
SetState(command_header);
|
|
dma_state.non_incrementing = true;
|
|
dma_increment_once = false;
|
|
break;
|
|
case SubmissionMode::Inline:
|
|
dma_state.method = command_header.method;
|
|
dma_state.subchannel = command_header.subchannel;
|
|
dma_state.dma_word_offset = u64(-s64(dma_state.dma_get)); // negate to set address as 0
|
|
CallMethod(command_header.arg_count);
|
|
dma_state.non_incrementing = true;
|
|
dma_increment_once = false;
|
|
break;
|
|
case SubmissionMode::IncreaseOnce:
|
|
SetState(command_header);
|
|
dma_state.non_incrementing = false;
|
|
dma_increment_once = true;
|
|
break;
|
|
default:
|
|
break;
|
|
}
|
|
index++;
|
|
}
|
|
}
|
|
}
|
|
|
|
void DmaPusher::SetState(const CommandHeader& command_header) {
|
|
dma_state.method = command_header.method;
|
|
dma_state.subchannel = command_header.subchannel;
|
|
dma_state.method_count = command_header.method_count;
|
|
}
|
|
|
|
void DmaPusher::CallMethod(u32 argument) {
|
|
if (dma_state.method < non_puller_methods) {
|
|
puller.CallPullerMethod(*this, Engines::Puller::MethodCall{
|
|
dma_state.method,
|
|
argument,
|
|
dma_state.subchannel,
|
|
dma_state.method_count,
|
|
});
|
|
} else {
|
|
auto subchannel = subchannels[dma_state.subchannel];
|
|
if (!subchannel->execution_mask[dma_state.method]) {
|
|
subchannel->method_sink.emplace_back(dma_state.method, argument);
|
|
} else {
|
|
subchannel->ConsumeSink(system);
|
|
subchannel->current_dma_segment = dma_state.dma_get + dma_state.dma_word_offset;
|
|
subchannel->CallMethod(system, dma_state.method, argument, dma_state.is_last_call);
|
|
}
|
|
}
|
|
}
|
|
|
|
void DmaPusher::CallMultiMethod(const u32* base_start, u32 num_methods) {
|
|
if (dma_state.method < non_puller_methods) {
|
|
puller.CallMultiMethod(*this, dma_state.method, dma_state.subchannel, base_start, num_methods, dma_state.method_count);
|
|
} else {
|
|
auto subchannel = subchannels[dma_state.subchannel];
|
|
subchannel->ConsumeSink(system);
|
|
subchannel->current_dma_segment = dma_state.dma_get + dma_state.dma_word_offset;
|
|
subchannel->CallMultiMethod(system, dma_state.method, base_start, num_methods, dma_state.method_count);
|
|
}
|
|
}
|
|
|
|
void DmaPusher::BindRasterizer(VideoCore::RasterizerInterface* rasterizer_) {
|
|
rasterizer = rasterizer_;
|
|
}
|
|
|
|
} // namespace Tegra
|