mirror of
https://git.eden-emu.dev/eden-emu/eden.git
synced 2026-08-24 16:30:44 +00:00
xbzk
b6ee847947
#3908 changed process_creation.*, CreateProcess/CreateApplicationProcess, to return std::optional<Process> instead of std::unique_ptr<Process>, so the AM sites now transfer a Process by value via make_unique<Service::Process>(*std::move(opt)). The consequence: Process owns a refcounted KProcess* but its user-declared dtor suppressed the implicit move ctor, so that "move" silently shallow-copied and the temporary's dtor Close()/RemoveProcess()'d the shared handle -> use-after-free. It's seems to be user end based, so whether it crashes may depend on machine, compiler, allocator reuse, refcount slack, and the AM event-observer thread race, idk. It reliably crashed my MSVC build at launching games (cstack: ProcessHolder -> MultiWait -> KSynchronizationObject::Wait -> null) multiple times. Fix: give Process a move ctor that steals the handle (nulling the source so the moved-from dtor is a no-op) and delete copy/move-assign, making the optional<->unique_ptr transfer safe. Bonus: explicited delete for the 3 kinds of assignment: copy ctor (the one used in eden), copy assign and move assign (currently unused) to force compile error if they ever come to use. Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4137 Reviewed-by: Lizzie <lizzie@eden-emu.dev> Reviewed-by: MaranBr <maranbr@eden-emu.dev>
73 lines
1.8 KiB
C++
73 lines
1.8 KiB
C++
// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
|
|
// SPDX-License-Identifier: GPL-3.0-or-later
|
|
|
|
// SPDX-FileCopyrightText: Copyright 2024 yuzu Emulator Project
|
|
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
#pragma once
|
|
|
|
#include <utility>
|
|
|
|
#include "common/common_types.h"
|
|
|
|
namespace Core {
|
|
class System;
|
|
}
|
|
|
|
namespace Loader {
|
|
class AppLoader;
|
|
enum class ResultStatus : u16;
|
|
} // namespace Loader
|
|
|
|
namespace Kernel {
|
|
class KProcess;
|
|
}
|
|
|
|
namespace Service {
|
|
|
|
class Process {
|
|
public:
|
|
inline explicit Process(Core::System& system) noexcept : m_system(system) {}
|
|
inline ~Process() { this->Finalize(); }
|
|
|
|
Process(const Process&) = delete;
|
|
Process& operator=(const Process&) = delete;
|
|
Process& operator=(Process&&) = delete;
|
|
inline Process(Process&& other) noexcept
|
|
: m_system(other.m_system), m_process(std::exchange(other.m_process, nullptr)),
|
|
m_main_thread_stack_size(std::exchange(other.m_main_thread_stack_size, 0)),
|
|
m_main_thread_priority(std::exchange(other.m_main_thread_priority, 0)),
|
|
m_process_started(std::exchange(other.m_process_started, false)) {}
|
|
|
|
bool Initialize(Loader::AppLoader& loader, Loader::ResultStatus& out_load_result);
|
|
void Finalize();
|
|
|
|
bool Run();
|
|
void Terminate();
|
|
void Suspend(bool suspended);
|
|
void ResetSignal();
|
|
|
|
bool IsInitialized() const {
|
|
return m_process != nullptr;
|
|
}
|
|
|
|
bool IsRunning() const;
|
|
bool IsTerminated() const;
|
|
|
|
u64 GetProcessId() const;
|
|
u64 GetProgramId() const;
|
|
|
|
Kernel::KProcess* GetHandle() const {
|
|
return m_process;
|
|
}
|
|
|
|
private:
|
|
Core::System& m_system;
|
|
Kernel::KProcess* m_process{};
|
|
u64 m_main_thread_stack_size{};
|
|
s32 m_main_thread_priority{};
|
|
bool m_process_started{};
|
|
};
|
|
|
|
} // namespace Service
|